Skip to content

Fix the broken "Show source" toggle for Ruby 3.4 docs #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the broken "Show source" toggle for Ruby 3.4 docs #2466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/docs/filters/rdoc/clean_html.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,24 @@ def other
node.remove_attribute 'id'
end

# Convert "click to toggle source" into a link
# (RDoc prior to Ruby 3.4) Convert "click to toggle source" into a link
css('.method-click-advice').each do |node|
node.name = 'a'
node.content = 'Show source'
end

# (RDoc for Ruby 3.4+) Add a "Show source" link
css('.method-source-toggle').each do |node|
link_node = Nokogiri::XML::Node.new('a', doc.document)
link_node.content = 'Show source'
link_node['class'] = 'method-click-advice'

node.parent.parent.at_css('.method-heading').add_child(link_node)
end

# (RDoc for Ruby 3.4+) Remove the additional "Source" toggle from the page
css('.method-controls').remove

# Add class to differentiate Ruby code from C code
css('.method-source-code').each do |node|
node.parent.prepend_child(node)
Expand Down