Skip to content

fix: remove deprecated android plugin "Registrar" #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −15
Open

fix: remove deprecated android plugin "Registrar" #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions android/src/main/java/com/freshchat/consumer/sdk/flutter/FreshchatSdkPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry;
import io.flutter.plugin.common.PluginRegistry.Registrar;


import com.freshchat.consumer.sdk.ConversationOptions;
Expand Down Expand Up @@ -79,20 +78,7 @@ public void onAttachedToEngine(@NonNull FlutterPluginBinding flutterPluginBindin
this);
}

public static void register(@NonNull PluginRegistry registry) {
if (registry == null) {
return;
}

registerWith(registry.registrarFor(PLUGIN_KEY));
}

// Keeping this public so it cane be used if needed
public static void registerWith(Registrar registrar) {
setupPlugin(registrar.context().getApplicationContext(),
registrar.messenger(),
new FreshchatSdkPlugin());
}

public static void setupPlugin(@NonNull Context context,
@NonNull BinaryMessenger messenger,
Expand Down Expand Up @@ -566,7 +552,7 @@ public void notifyAppLocaleChange() {
public void dismissFreshchatView() {
Intent dismissIntent = new Intent("com.freshchat.consumer.sdk.actions.DismissFreshchatScreens");
LocalBroadcastManager.getInstance(context).sendBroadcast(dismissIntent);
}
}

@Override
public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {
Expand Down