Skip to content

Conversation

@prabhuteja12
Copy link

Hi,
This pull request is to include the IMDb LSTM sentiment classification task (from https://arxiv.org/abs/1910.11758 )
I've added the dataset, network architecture, and I've tested it with the example code in the examples/runner_momentum_pytorch.py as a sanity check.

@fsschneider
Copy link
Owner

That is great, thank you so much. I hope in a few days I have some time to merge it.

I want to add a "contributors" section to the readme. Would it be okay with you if I added you (and possibly your co-authors) to this list? I want to make sure I properly acknowledge you for contributing.

@prabhuteja12
Copy link
Author

prabhuteja12 commented Nov 14, 2019

Sure., You can add me (@prabhuteja12) @florianmai as contributors.

There seem to have been some checks failed. Should I send another pull request fixing them?

@fsschneider
Copy link
Owner

Thanks, I will.
Don't worry about the checks. They are currently not perfectly set up and alert on some false positives. I will fix this.
Thanks again for your contribution.

@prabhuteja12
Copy link
Author

Hi,
I accidentally made a few changes to my rep and it resulted in an update to the pull request. I think i've fixed the accidental errors induced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants