Make WebHDFS ls() method compatible with superclass by supporting **kwargs #1928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current WebHDFS.ls() implementation does not accept additional parameters, which breaks compatibility with newer versions of JupyterFS (e.g., jupyterfs==1.1.0).
Since we abstract filesystem interfaces, all common methods (such as ls, info, etc.) should accept **kwargs to ensure forward compatibility with upstream fsspec and JupyterFS expectations.
For example, JupyterFS 1.1.0 calls fs.ls(..., refresh=True) internally, which raises:
TypeError: WebHDFS.ls() got an unexpected keyword argument 'refresh'
Reference:
https://github.com/jpmorganchase/jupyter-fs/blob/6fac72f9a047871de48b757c5634317f88b5ac77/jupyterfs/manager/fsspec.py#L188
Proposed fix:
Update WebHDFS.ls() signature to accept **kwargs as it implemented for other filesystems (e.g. local)