Handle spaces that are encoded as '+' in gh_decode #5
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's valid to encode spaces in URLs as '+' characters. According to w3 recommendations, "Space characters are replaced by `+', and then reserved characters are escaped..."; jQuery's built in .param method does this:
{{{
Since CFURLCreateStringByReplacingPercentEscapes does not handle spaces encoded as '+', and I was unable to find a CoreFoundation that handled both percent escaping and spaces, the quick fix is to manually replace '+' characters with spaces. Any intentional '+' characters should already be encoded as %2B.
See also:
http://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20