Add remap option to rerun_invocation() method #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Oct 25, 2021
| return self._get(url=url) | ||
|
|
||
| def rerun_invocation(self, invocation_id: str, inputs_update: Optional[dict] = None, | ||
| def rerun_invocation(self, invocation_id: str, remap: bool = False, inputs_update: Optional[dict] = None, |
There was a problem hiding this comment.
Instead of adding remap here, I think it would be better to add a separate method (rerun_invocation_failed_jobs() maybe?). The implementation for remap=True doesn't share any code with the current one.
There was a problem hiding this comment.
I can also add it as a separate method. The rationale of doing it this way was so that rerun_invocation() would work exactly the same as rerun_job() - either create an entire new job/invocation with remap=False or replace the existing failed one in place with remap=True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nsoranzo here is a new PR with only the remapping functionality from #395, to avoid the more complex discussion about how to submit the runtime parameters for now. Could you have a look please?