feat: bump toolset and unity-changeset #67
Conversation
|
Warning Rate limit exceeded@webbertakken has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
WalkthroughRepository configuration updates: add Yarn ignore entries, set Yarn nodeLinker to node-modules, add/standardize Yarn v4 packageManager metadata and Volta fields, bump Node engine metadata to Node 22 in functions and root tooling, remove GraphQL and bump unity-changeset in functions, set Firebase Functions runtime to nodejs24, and update GitHub Actions to install dependencies via Yarn before build/test/deploy. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer / PR
participant GH as GitHub Actions
participant Corepack as Corepack (yarn)
participant Node as Node toolchain (from package.json)
participant YarnRoot as Yarn (root)
participant YarnFns as Yarn (functions)
participant Firebase as Firebase Deploy
Dev->>GH: push PR
GH->>Corepack: enable/install corepack
GH->>Node: setup Node (node-version-file: package.json)
GH->>YarnRoot: run `yarn install --immutable`
GH->>YarnFns: run `yarn --cwd ./functions install --immutable`
alt build/test
GH->>GH: run lint, tests, build
end
alt deploy
GH->>Firebase: predeploy & deploy functions (runtime: nodejs24)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks good to me, let's merge when the pipeline is green 🚀 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
functions/package.json (1)
15-50: Pinned Node 24 requirement breaks Firebase deployment.Because Cloud Functions only offers Node runtimes up to 22 today, setting both the
engines.nodefield and Volta/tooling metadata to Node 24 makesyarn installfail during deploy and contradicts the platform runtime. Please revert to Node 20 (or another supported version) across these fields until Firebase enables Node 24.- "node": "24" + "node": "20" @@ - "volta": { - "node": "24.9.0", - "yarn": "4.10.3" - }, - "packageManager": "[email protected]" + "volta": { + "node": "20.17.0", + "yarn": "4.10.3" + }, + "packageManager": "[email protected]"(Adjust the exact Node 20.x patch as appropriate.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
functions/yarn.lockis excluded by!**/yarn.lock,!**/*.lockyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
.gitignore(1 hunks).yarnrc.yml(1 hunks)firebase.json(1 hunks)functions/package.json(3 hunks)package.json(1 hunks)
| "volta": { | ||
| "node": "24.9.0", | ||
| "yarn": "4.10.3" | ||
| }, | ||
| "packageManager": "[email protected]" |
There was a problem hiding this comment.
Keep repo Volta/Node settings aligned with supported runtime.
Since the deployment target cannot run Node 24 yet, this new Volta block will steer contributors toward an unsupported version. Please match the Cloud Functions runtime (currently Node 20) so local tooling mirrors production.
- "volta": {
- "node": "24.9.0",
- "yarn": "4.10.3"
- },
+ "volta": {
+ "node": "20.17.0",
+ "yarn": "4.10.3"
+ },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "volta": { | |
| "node": "24.9.0", | |
| "yarn": "4.10.3" | |
| }, | |
| "packageManager": "[email protected]" | |
| "volta": { | |
| "node": "20.17.0", | |
| "yarn": "4.10.3" | |
| }, | |
| "packageManager": "[email protected]" |
🤖 Prompt for AI Agents
In package.json around lines 34 to 38, the Volta node version is set to 24.9.0
which diverges from the deployed Cloud Functions runtime; update the
"volta.node" value to the Node 20 runtime used in production (e.g., "20" or the
exact Cloud Functions patch version) so local tooling matches the supported
environment, leaving the yarn entry unchanged.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test Deploy
`Test Deploy (pull_request)` job is failing
What would you do? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3552 🏁 Script executed: Length of output: 716 🏁 Script executed: Length of output: 136 @GabLeRoux, I can see the issue! The problem is that the Root CauseWhen Firebase CLI tries to run the Recommended SolutionRemove the {
"firestore": {
"rules": "firestore.rules",
"indexes": "firestore.indexes.json"
},
"functions": {
"runtime": "nodejs24"
},
"hosting": {
"public": "public",
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
]
},
"storage": {
"rules": "storage.rules"
},
"emulators": {
"functions": {
"port": 5001
},
"firestore": {
"port": 8080
},
"hosting": {
"port": 5002
},
"pubsub": {
"port": 8085
},
"ui": {
"enabled": true
}
}
}This eliminates the redundant predeploy steps that are already handled by your CI pipeline. Why This WorksLooking at your workflow, you already have proper gates in place:
So the predeploy hooks are unnecessary duplication and only cause issues with the Yarn version mismatch in the Firebase Action container. 🐰 |
For reference, this was not the fix. There was a |
|
We should probably remove this hack after w9jds/firebase-action#256 is resolved |
Changes
Checklist
Summary by CodeRabbit
Chores
CI