Skip to content

Enable persona filtering #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Enable persona filtering #695

merged 1 commit into from
Sep 12, 2025
+4 −349

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Aug 12, 2025 •
edited
Loading

This PR enables the persona filtering js plugin through the docforge manifest

Release note:

NONE

@Kostov6 Kostov6 requested a review from a team as a code owner August 12, 2025 12:59
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 12, 2025
marc1404
marc1404 reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kostov6! Have you tried this locally? The entire implementation of persona filtering in VitePress is new.. I have doubts about whether the current filtering.js generated by Docforge works with the new setup 🤔

klocke-io
klocke-io approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@klocke-io klocke-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm,

Thanks for taking care of it

@klocke-io klocke-io merged commit 7f72703 into gardener:master Sep 12, 2025
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 left review comments

@klocke-io klocke-io klocke-io approved these changes

Assignees
No one assigned
Labels
needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kostov6 @marc1404 @klocke-io @gardener-robot