CI/Lint: Add pyright and isort to the project
#168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteOtter
changed the title
pyright and isort to the project
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 91.08% 91.08%
=======================================
Files 27 27
Lines 1234 1234
=======================================
Hits 1124 1124
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ByteOtter
force-pushed
the
ci/add-linters
branch
from
fc81ae1 to
d14ca8f
Compare
|
So far, this PR is done. The linting CI has been improved by adding |
ByteOtter
force-pushed
the
ci/add-linters
branch
from
a25f0e4 to
46b46ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To improve general code quality (and also safety) this PR adds
pyrightandisortto the project for linting and import sorting respectively.Later I will also gradually address all the
errorsthepyrightlinter finds in accordance to it'spyrightconfig.jsonand its strict mode rulesTo not make it too noisy, I downgraded some of its default
errorsdown towarningsif they are non-critical edge-cases or more style related than functional.Another goal is to gradually add proper type annotations to the codebase in future PRs.
Which issue(s) this PR fixes:
Tracks (not fully fixes) #152