Skip to content

Conversation

NotTheEvilOne
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne commented Sep 1, 2025

What this PR does / why we need it:
This PR adds support for gl-oci to additionally tag an OCI manifest. It mainly reuses already existing code paths.

Which issue(s) this PR fixes:
Related gardenlinux/gardenlinux#2753

Special notes for your reviewer:
This PR will be tagged 0.9.1.

@NotTheEvilOne NotTheEvilOne self-assigned this Sep 1, 2025
@NotTheEvilOne NotTheEvilOne added the enhancement New feature or request label Sep 1, 2025
@NotTheEvilOne NotTheEvilOne added this to the 2025-09 milestone Sep 1, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 95.58824% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.95%. Comparing base (0d32884) to head (6d68a09).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/oci/image_manifest.py 94.18% 5 Missing ⚠️
src/gardenlinux/oci/container.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   90.98%   92.95%   +1.97%     
==========================================
  Files          27       28       +1     
  Lines        1264     1306      +42     
==========================================
+ Hits         1150     1214      +64     
+ Misses        114       92      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne NotTheEvilOne force-pushed the feature/oci-push-manifest-tags-support branch from cd0c991 to 7649e71 Compare September 1, 2025 15:59
Copy link
Contributor

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. Just CodeCov complaining about coverage. :)

@NotTheEvilOne NotTheEvilOne force-pushed the feature/oci-push-manifest-tags-support branch 10 times, most recently from 1604620 to 33f4085 Compare September 10, 2025 14:08
@NotTheEvilOne NotTheEvilOne force-pushed the feature/oci-push-manifest-tags-support branch from 33f4085 to 9829a63 Compare September 10, 2025 14:20
@NotTheEvilOne NotTheEvilOne force-pushed the feature/oci-push-manifest-tags-support branch 2 times, most recently from efc13c6 to 8a4d949 Compare September 15, 2025 07:40
@NotTheEvilOne NotTheEvilOne force-pushed the feature/oci-push-manifest-tags-support branch from 8a4d949 to 6d68a09 Compare September 15, 2025 07:42
Copy link
Contributor

@yeoldegrove yeoldegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not completely grasp if adding this breaks our current workflows (if there is a version bump).
Did you already look into this?

Other than that, looks good to me.

@NotTheEvilOne
Copy link
Contributor Author

I did not completely grasp if adding this breaks our current workflows (if there is a version bump). Did you already look into this?

Other than that, looks good to me.

It's adding a new entrypoint after all so current workflows should not be affected at all.

@NotTheEvilOne NotTheEvilOne merged commit 8158f4a into main Sep 16, 2025
11 checks passed
@NotTheEvilOne NotTheEvilOne deleted the feature/oci-push-manifest-tags-support branch September 16, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants