-
Notifications
You must be signed in to change notification settings - Fork 2
Add support to additionally tag an existing OCI manifest #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 90.98% 92.95% +1.97%
==========================================
Files 27 28 +1
Lines 1264 1306 +42
==========================================
+ Hits 1150 1214 +64
+ Misses 114 92 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd0c991
to
7649e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Just CodeCov complaining about coverage. :)
1604620
to
33f4085
Compare
33f4085
to
9829a63
Compare
Signed-off-by: Tobias Wolf <[email protected]>
efc13c6
to
8a4d949
Compare
Signed-off-by: Tobias Wolf <[email protected]>
8a4d949
to
6d68a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not completely grasp if adding this breaks our current workflows (if there is a version bump).
Did you already look into this?
Other than that, looks good to me.
It's adding a new entrypoint after all so current workflows should not be affected at all. |
What this PR does / why we need it:
This PR adds support for
gl-oci
to additionally tag an OCI manifest. It mainly reuses already existing code paths.Which issue(s) this PR fixes:
Related gardenlinux/gardenlinux#2753
Special notes for your reviewer:
This PR will be tagged 0.9.1.