Skip to content

Conversation

NotTheEvilOne
Copy link
Contributor

What this PR does / why we need it:
This PR replaces GitPython implementation with pygit2. This allows proper handling of Git checkouts.

Which issue(s) this PR fixes:
Fixes #186

@NotTheEvilOne NotTheEvilOne self-assigned this Sep 14, 2025
@NotTheEvilOne NotTheEvilOne added the enhancement New feature or request label Sep 14, 2025
@NotTheEvilOne NotTheEvilOne force-pushed the branch/transition-to-pygit2 branch 3 times, most recently from 1e9df9b to fdc1567 Compare September 14, 2025 14:33
@NotTheEvilOne NotTheEvilOne force-pushed the branch/transition-to-pygit2 branch from fdc1567 to f0f6069 Compare September 14, 2025 14:39
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.98%. Comparing base (c67c28b) to head (f0f6069).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/git/repository.py 90.32% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   91.08%   90.98%   -0.11%     
==========================================
  Files          27       27              
  Lines        1234     1264      +30     
==========================================
+ Hits         1124     1150      +26     
- Misses        110      114       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne NotTheEvilOne marked this pull request as ready for review September 14, 2025 14:48
Copy link
Contributor

@yeoldegrove yeoldegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you rename the whole class again.
Other than that, moving to pygit2 is fine.

@NotTheEvilOne NotTheEvilOne merged commit 0d32884 into main Sep 15, 2025
14 of 15 checks passed
@NotTheEvilOne NotTheEvilOne deleted the branch/transition-to-pygit2 branch September 15, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition from GitPython because of missing features
2 participants