Use aiohttp instead of requests in feed plugin #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienPalard
force-pushed
the
mdk-aiohttp
branch
from
a4fc12c to
041223b
Compare
|
Hi, Can you rebase this one on master? Don't remember why the tests was broken. Maybe it'll work now...? :) |
JulienPalard
force-pushed
the
mdk-aiohttp
branch
2 times, most recently
from
720c664 to
9a26f1f
Compare
|
IIRC while working on this PR I went shaving yaks, ultimately leading to #201 without taking the time to finish this one... (then je me suis fait déconcentrer par mes contributions à sphinx-lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted that
--debugwas not documented, so I added it, in the right place I hope.Spotted a deprecated mention of
buildout, replaced it with a mention ofpip install ..Flake8 spotted an unused
import typesincompat, I hope it's not a false positive, fixed it because I bet the CI won't pass if it's not fixed.But the main task was replacing aiohttp with requests in the feed plugin.