chore: dropped support for python 3.9 #1072

tm91236 · 2025-09-16T08:05:30Z

PR Type

Refactoring (no functional changes)
Build related changes
CI related changes
Tests

Description

Drops support for python 3.9

How Has This Been Tested?

Existing tests pass as expected.

Does this PR introduce a breaking change?

Drops support for python 3.9

Checklist before requesting a review

I have made sure that my PR is not a duplicate.
My code follows the style guidelines of this project.
I have ensured my code is easy to understand, including docstrings and comments where necessary.
I have performed a self-review of my code.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
New and existing unit tests pass locally with my changes.
Any dependent changes have been merged and published in downstream modules.
I have updated CHANGELOG.md, if appropriate.

github-actions · 2025-09-16T08:06:54Z

Performance review

Commit `bf580d1` - Merge `a953ee8` into `7637bd3`

Statistically significant changes

basic_rpc:
- OLD: compilation 1.119 units ± 0.03089 units; execution 0.02146 units ± 0.0006256 units
- NEW: compilation 1.126 units ± 0.08764 units; execution 0.04305 units ± 0.0009212 units
- Significant increase in execution time (100.65%, p=2.893e-20)

Normalisation values for new data:
Compilation: 1 unit = 307.65 ms
Execution: 1 unit = 803.04 ms

github-actions · 2025-09-17T15:09:54Z

Performance review

Commit `d19954b` - Merge `37ed967` into `7637bd3`

Statistically significant changes

basic_herding:
- OLD: compilation 0.9736 units ± 0.06033 units; execution 0.1695 units ± 0.007192 units
- NEW: compilation 1.013 units ± 0.04762 units; execution 0.08712 units ± 0.001803 units
- Significant decrease in execution time (-48.60%, p=6.454e-12)
basic_rpc:
- OLD: compilation 1.119 units ± 0.03089 units; execution 0.02146 units ± 0.0006256 units
- NEW: compilation 1.125 units ± 0.02731 units; execution 0.01916 units ± 0.0003377 units
- Significant decrease in execution time (-10.72%, p=7.862e-08)
basic_stein:
- OLD: compilation 5.578 units ± 0.3345 units; execution 0.4053 units ± 0.01145 units
- NEW: compilation 5.911 units ± 0.2881 units; execution 0.3043 units ± 0.01006 units
- Significant decrease in execution time (-24.93%, p=6.005e-14)

Normalisation values for new data:
Compilation: 1 unit = 298.04 ms
Execution: 1 unit = 825.96 ms

github-actions · 2025-09-29T12:21:50Z

Performance review

Commit `7f424ae` - Merge `6baca8c` into `b91240b`

Statistically significant changes

basic_rpc:
- OLD: compilation 1.08 units ± 0.05293 units; execution 0.02258 units ± 0.0005381 units
- NEW: compilation 1.118 units ± 0.1052 units; execution 0.04353 units ± 0.001377 units
- Significant increase in execution time (92.77%, p=1.932e-14)

Normalisation values for new data:
Compilation: 1 unit = 313.91 ms
Execution: 1 unit = 811.67 ms

gchqdev227

It all looks good (and tests pass), but a few clarifying questions to be answered before approval please!

.pre-commit-config.yaml

coreax/data.py

coreax/kernels/base.py

tests/performance/compare.py

tests/unit/test_score_matching.py

tests/unit/test_solvers.py

uv.lock

github-actions · 2025-10-01T09:36:32Z

Performance review

Commit `9c82a80` - Merge `d13132c` into `b91240b`

Statistically significant changes

basic_herding:
- OLD: compilation 0.9221 units ± 0.0582 units; execution 0.1726 units ± 0.008165 units
- NEW: compilation 0.9366 units ± 0.03867 units; execution 0.09283 units ± 0.003057 units
- Significant decrease in execution time (-46.20%, p=4.414e-12)
basic_rpc:
- OLD: compilation 1.08 units ± 0.05293 units; execution 0.02258 units ± 0.0005381 units
- NEW: compilation 1.022 units ± 0.02838 units; execution 0.02007 units ± 0.0002972 units
- Significant decrease in execution time (-11.12%, p=3.558e-09)
basic_stein:
- OLD: compilation 5.233 units ± 0.3016 units; execution 0.4087 units ± 0.01033 units
- NEW: compilation 5.389 units ± 0.323 units; execution 0.3328 units ± 0.005711 units
- Significant decrease in execution time (-18.58%, p=8.189e-12)

Normalisation values for new data:
Compilation: 1 unit = 350.23 ms
Execution: 1 unit = 799.76 ms

github-actions · 2025-10-27T15:25:47Z

Performance review

Commit `74a87be` - Merge `37672f4` into `b91240b`

Statistically significant changes

basic_herding:
- OLD: compilation 0.9221 units ± 0.0582 units; execution 0.1726 units ± 0.008165 units
- NEW: compilation 1.094 units ± 0.03889 units; execution 0.08897 units ± 0.002299 units
- Significant increase in compilation time (18.67%, p=9.027e-07)
- Significant decrease in execution time (-48.44%, p=1.263e-11)
basic_rpc:
- OLD: compilation 1.08 units ± 0.05293 units; execution 0.02258 units ± 0.0005381 units
- NEW: compilation 1.31 units ± 0.02932 units; execution 0.01956 units ± 0.000315 units
- Significant increase in compilation time (21.26%, p=8.993e-09)
- Significant decrease in execution time (-13.37%, p=2.318e-10)
basic_stein:
- OLD: compilation 5.233 units ± 0.3016 units; execution 0.4087 units ± 0.01033 units
- NEW: compilation 5.005 units ± 0.3641 units; execution 0.3124 units ± 0.01414 units
- Significant decrease in execution time (-23.55%, p=4.982e-12)

Normalisation values for new data:
Compilation: 1 unit = 315.12 ms
Execution: 1 unit = 810.19 ms

gchqdev227

Happy to approve provided the tests pass!

See if the test failures subside on the latest public preview of the MacOS runners.

github-actions · 2025-10-27T16:15:50Z

Performance review

Commit `d4f5fb9` - Merge `e07ce55` into `b91240b`

Statistically significant changes

basic_herding:
- OLD: compilation 0.9221 units ± 0.0582 units; execution 0.1726 units ± 0.008165 units
- NEW: compilation 1.066 units ± 0.03412 units; execution 0.09109 units ± 0.002656 units
- Significant increase in compilation time (15.61%, p=7.703e-06)
- Significant decrease in execution time (-47.21%, p=8.168e-12)
basic_rpc:
- OLD: compilation 1.08 units ± 0.05293 units; execution 0.02258 units ± 0.0005381 units
- NEW: compilation 1.27 units ± 0.01909 units; execution 0.01948 units ± 0.0002778 units
- Significant increase in compilation time (17.63%, p=2.945e-07)
- Significant decrease in execution time (-13.72%, p=3.222e-10)
basic_stein:
- OLD: compilation 5.233 units ± 0.3016 units; execution 0.4087 units ± 0.01033 units
- NEW: compilation 4.963 units ± 0.251 units; execution 0.3111 units ± 0.009596 units
- Significant decrease in execution time (-23.87%, p=2.277e-14)

Normalisation values for new data:
Compilation: 1 unit = 321.1 ms
Execution: 1 unit = 815.01 ms

tm91236 force-pushed the chore/drop-python-3.9 branch from a953ee8 to 37ed967 Compare September 17, 2025 15:08

chore: dropped support for python 3.9

6baca8c

tm91236 force-pushed the chore/drop-python-3.9 branch from 37ed967 to 6baca8c Compare September 29, 2025 12:20

gchqdev227 reviewed Oct 1, 2025

View reviewed changes

fix: minor type hint errors missed by autofix.

d13132c

chore: update uv.lock

37672f4

gchqdev227 previously approved these changes Oct 27, 2025

View reviewed changes

tm91236 added 2 commits October 27, 2025 16:11

chore(docs): fix typing union warning.

2c2d8a2

fix(ci): trial macos-26 public preview.

e07ce55

See if the test failures subside on the latest public preview of the MacOS runners.

tm91236 dismissed gchqdev227’s stale review via e07ce55 October 27, 2025 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: dropped support for python 3.9 #1072

chore: dropped support for python 3.9 #1072

Uh oh!

tm91236 commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

gchqdev227 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

gchqdev227 left a comment

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: dropped support for python 3.9 #1072

Are you sure you want to change the base?

chore: dropped support for python 3.9 #1072

Uh oh!

Conversation

tm91236 commented Sep 16, 2025

PR Type

Description

How Has This Been Tested?

Does this PR introduce a breaking change?

Checklist before requesting a review

Uh oh!

github-actions bot commented Sep 16, 2025

Performance review

Commit bf580d1 - Merge a953ee8 into 7637bd3

Statistically significant changes

Uh oh!

github-actions bot commented Sep 17, 2025

Performance review

Commit d19954b - Merge 37ed967 into 7637bd3

Statistically significant changes

Uh oh!

github-actions bot commented Sep 29, 2025

Performance review

Commit 7f424ae - Merge 6baca8c into b91240b

Statistically significant changes

Uh oh!

gchqdev227 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2025

Performance review

Commit 9c82a80 - Merge d13132c into b91240b

Statistically significant changes

Uh oh!

github-actions bot commented Oct 27, 2025

Performance review

Commit 74a87be - Merge 37672f4 into b91240b

Statistically significant changes

Uh oh!

gchqdev227 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 27, 2025

Performance review

Commit d4f5fb9 - Merge e07ce55 into b91240b

Statistically significant changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Commit `bf580d1` - Merge `a953ee8` into `7637bd3`

Commit `d19954b` - Merge `37ed967` into `7637bd3`

Commit `7f424ae` - Merge `6baca8c` into `b91240b`

Commit `9c82a80` - Merge `d13132c` into `b91240b`

Commit `74a87be` - Merge `37672f4` into `b91240b`

Commit `d4f5fb9` - Merge `e07ce55` into `b91240b`