Add support for DATA packets #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. This is quite an important fix. Is this implementation unmaintained? |
|
@issacg, I'm a new Gearman::Client co maintainer. I'm working on the project in my own repo because lack of permissions for this repo. It's a pity that I didn't realize your PL sooner. It would be great if you could create a new PL on my repo. Otherwise I'll do it on my own. |
|
@p-alik I don't have cycles free at the moment to port it - if you have the time and availability to do it, you have my blessings :) Thanks! |
p-alik
added a commit
to p-alik/perl-Gearman
that referenced
this pull request
Oct 27, 2016
p-alik
added a commit
to p-alik/perl-Gearman
that referenced
this pull request
Oct 27, 2016
p-alik
added a commit
to p-alik/perl-Gearman
that referenced
this pull request
Jan 28, 2017
p-alik
added a commit
to p-alik/perl-Gearman
that referenced
this pull request
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should allow very rudementary support for WORK_DATA packets. At the very least it won't cause Gearman::Client to die with "Unknown/unimplemented packet type" when one is encountered.