Add a generic parameter <E> to getExternalInstance #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid getting warning: [unchecked] unchecked cast when generated code uses this method. So now instead of being declared as public ArrayList getExternalInstance() it is declared as public <E> ArrayList<E> getExternalInstance() with <E> being the type parameter. You can then call the method passing an explicit parameter, e.g.: chatHistory.<OpenAIResponse.Message>getExternalInstance(); which we currently don't generate, but just using chatHistory.getExternalInstance(); also does not yield a warning.
Cherry pick to beta success |
iroqueta
approved these changes
Jul 11, 2025
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid getting
warning: [unchecked] unchecked castwhen generated code uses this method. So now instead of being declared aspublic ArrayList getExternalInstance()it is declared as
public <E> ArrayList<E> getExternalInstance()with being the type parameter.
You can then call the method passing an explicit parameter, e.g.:
chatHistory.<OpenAIResponse.Message>getExternalInstance();which we currently don't generate, but just using
chatHistory.getExternalInstance();also does not yield a warning.
Issue: 205291