Skip to content

Scale tracers by pressure ratio in first timestep #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: gchp/dev
Choose a base branch
from
Draft

Scale tracers by pressure ratio in first timestep #11

wants to merge 14 commits into from

Conversation

lizziel
Copy link

@lizziel lizziel commented Oct 3, 2025 •
edited
Loading

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR makes the following changes:

  1. Adds import DELPDRY which is the GEOS-Chem restart file field DELP_DRY
  2. Adds new subroutine to scale tracers by ratio of import delta pressure from GEOS-Chem (ultimately from restart file) and delta pressure computed from import meteorology
  3. Applies scaling in the first timestep only, prior to the call to offline advection, so that species mass in restart file is conserved
  4. Removes compiler option PRINT_MASS which was not implemented into GCHP
  5. Adds config file option (in GCHP.rc) to turn on printing global mass proxy in advection, for investigating mass conservation
  6. Adds option debug prints, and associated subroutines for global mass sums, within the mass print blocks that can be uncommented for mass conservation debugging

This PR must be merged at the same time as two companion PRs:
geoschem/geos-chem#3062
geoschem/GCHP#515

Expected changes

This update results in small differences in all species in all GCHP simulations. GEOS-Chem Classic is not affected.

Reference(s)

None

Related Github Issue

geoschem/geos-chem#2536

lizziel added 14 commits October 2, 2025 14:42
@lizziel
Add import DELPDRY
2019f0d 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Add subroutine to scale tracers by ratio or restart deltaP to model d…
e295fac 
…eltaP

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Move setting firstRun to false to end of AdvCore run
7bf03e9 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Remove unused compiler option PRINT_MASS
b0f18db 
The code in this block is only enabled by local variable chk_mass which is
set to false by default. To avoid confusion PRINT_MASS is now removed.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Scale tracer mixing ratios by pressure ratio
7383769 
Use different model pressure based on if advection is on/off and if using
total or dry air pressure in advection. Only scale if DELPDRY import
is found and it contains non-zero values, meaning it was present in
the restart file.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Reduce tracer mass prints to one species (first species) only
3f7cdad 
This enables using the mass prints for single species simulations such as
the carbon simulation.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Make check mass conservation a config file option
3c2e245 
This avoids having to recompile code when turning this functionality
on/off.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Add additional global_integral subroutines and declare private
ea71514 
The new subroutines give various options to computing global sums,
including sum of mixing ratios, delta pressures from model pressure,
import delta pressures, species proxy mass using import delta pressure,
and species proxy mass using model pressure. These functionalities are
useful for checking mass conservation.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Simplify ne subroutine scale_tracers_by_pressure_ratio
4838887 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Remove pressure unit conversion since now occurs in GEOS-Chem
357c91a 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Apply corrected tracer scaling
e6546c4 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Restore legacy mass print computation with improved logic and comments
78a1725 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Add commented out optional debug for future debugging and validation
8d771e6 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Rename config entry for mass prints in advection
4f406aa 
This entry should appear in GCHP config file GCHP.rc.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel lizziel added the enhancement New feature or request label Oct 3, 2025
This was referenced Oct 3, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lizziel