Skip to content

assert that offset is an integer #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

assert that offset is an integer #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abdd72e
assert that offset is an integer
ldanilek Mar 6, 2025
f9b662e
.
ldanilek Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/component/btree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,12 @@ export async function atOffsetHandler(
ctx: { db: DatabaseReader },
args: { offset: number; k1?: Key; k2?: Key; namespace?: Namespace }
) {
if (args.offset < 0) {
throw new Error("offset must be non-negative");
}
if (args.offset !== Math.floor(args.offset)) {
throw new Error("offset must be an integer");
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use Number.isInteger

const tree = await getTree(ctx.db, args.namespace);
if (tree === null) {
throw new ConvexError("tree is empty");
Expand All @@ -394,6 +400,12 @@ export async function atNegativeOffsetHandler(
ctx: { db: DatabaseReader },
args: { offset: number; k1?: Key; k2?: Key; namespace?: Namespace }
) {
if (args.offset < 0) {
throw new Error("offset must be non-negative");
}
if (args.offset !== Math.floor(args.offset)) {
throw new Error("offset must be an integer");
}
const tree = await getTree(ctx.db, args.namespace);
if (tree === null) {
throw new ConvexError("tree is empty");
Expand Down
Loading