-
Notifications
You must be signed in to change notification settings - Fork 418
dev improvements #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev improvements #457
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about the set of template snapshots deleted + added here -- looks like there's a new one that we don't reference anywhere, and we've deleted some of the older ones?
I've been a little hesitant to delete the older ones immediately since it could break older frontend sessions, but are we ok with breakage / has it been long enough?
|
|
||
| Run `npm run rebuild-template` for directions. | ||
|
|
||
| # Debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we can't namespace them? like window.CHEF_DEBUG.webcontainer
|
that's a mistake, I should have kept these around. Since they're small it doesn't hurt anything to keep them around I can bring them back now. Ideally I guess we want ever snapshot that has ever been deployed to release to stay there, and ideal would be for them to live forever in some S3 bucket somewhere? |
All the extra stuff I added in #417 without the linting