Skip to content

Conversation

@thomasballinger
Copy link
Collaborator

All the extra stuff I added in #417 without the linting

@vercel
Copy link

vercel bot commented Apr 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chef ✅ Ready (Inspect) Visit Preview Apr 20, 2025 8:05pm

@thomasballinger thomasballinger added this pull request to the merge queue Apr 21, 2025
Merged via the queue into main with commit 92ef1d7 Apr 21, 2025
2 checks passed
@thomasballinger thomasballinger deleted the tom/most-of-eslint-pr branch April 21, 2025 18:50
Copy link
Contributor

@sshader sshader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the set of template snapshots deleted + added here -- looks like there's a new one that we don't reference anywhere, and we've deleted some of the older ones?

I've been a little hesitant to delete the older ones immediately since it could break older frontend sessions, but are we ok with breakage / has it been long enough?


Run `npm run rebuild-template` for directions.

# Debugging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we can't namespace them? like window.CHEF_DEBUG.webcontainer

@thomasballinger
Copy link
Collaborator Author

thomasballinger commented Apr 21, 2025

that's a mistake, I should have kept these around. Since they're small it doesn't hurt anything to keep them around I can bring them back now. Ideally I guess we want ever snapshot that has ever been deployed to release to stay there, and ideal would be for them to live forever in some S3 bucket somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants