For Fusion, allow quoting dict in string #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-per
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
|
I also just raised dbt-labs/dbt-fusion#1000 that seems to be impacting the package when trying to retrieve the thread being used for a model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
When reviewing Fusion compatibility, I saw that the integration tests were not behaving as expected in Fusion.
The integration test project was just not compiling in Fusion due to the fact that
query_tagis strictly checked to make sure that it is a string, and not a dict.So, the approach I am suggesting is to allow quoting a dict in an overall string which seems to work. I update the README as well.
Let me know what you think!