Skip to content

Conversation

@dacog
Copy link

@dacog dacog commented Mar 29, 2025

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

I added the Bootstrap 5 and Bootblog5 themes for Bootstrap 5.3.

I did the following:

  • I updated the bootstrap 4 mako versions with the new classes and libraries.
  • I added support to jinjify.py for the new themes, and used it to create the jinja versions.
  • I added support for the new libraries along the old lobraries (bootstrap 4 and bootstrap5) using aliases in package.json
  • I added support for the new themes and libraries in the update-npm-assets.sh and run it to add the assets for the new themes.
  • I updated the subtheme command to support bootstrap 5

I could not find baguetteBox-links-with-images-only.patch to patch baguetteBox. Is this still required?

I tested by installing my modified nikola locally (pip install -e .) and created a new demo site.
Then I used a demo site (nikola init -qd) and run a nikola build -a for each theme.
I then created a new subtheme nikola subtheme -p bootstrap5 -n daco -s journal and checked that it was ok.

I think that was in summary.

Somewhere I read that nikola uses the jinjify.py to create the jinja versions, that is why I created the mako versions first and updated the scripts so that they worked with the new versions.

Here is the home of the demo for each new theme as examples.

Screenshot 2025-03-29 at 17-46-04 Demo Site-bootblog5
Screenshot 2025-03-29 at 17-47-04 Demo Site-bootblog5-jinja
Screenshot 2025-03-29 at 17-48-14 Demo Site-bootstrap5
Screenshot 2025-03-29 at 17-49-01 Demo Site-bootstrap5-jinja
Screenshot 2025-03-29 at 18-40-12 Demo Site-nwe-subtheme-journal

I hope this helps. Let me know if I need to change anything.

Best,

Diego

@dacog dacog mentioned this pull request Mar 29, 2025
@X1aomu
Copy link

X1aomu commented Aug 8, 2025

Thanks for the new themes, I've tried something out but they are not working.

Just found that some file was commit as symlink that link to you local path.

Check these files:

  • nikola/data/themes/bootblog5/assets/css/bootstrap.min.css
  • nikola/data/themes/bootblog5/assets/js/bootstrap.min.js
  • nikola/data/themes/bootblog5/assets/js/luxon.min.js
  • nikola/data/themes/bootblog5-jinja/assets/css/bootstrap.min.css
  • nikola/data/themes/bootstrap5/assets/css/bootstrap.min.css
  • nikola/data/themes/bootstrap5/assets/js/bootstrap.min.js
  • nikola/data/themes/bootstrap5/assets/js/luxon.min.js
  • nikola/data/themes/bootstrap5/assets/js/popper.min.js
  • nikola/data/themes/bootstrap5-jinja/assets/css/bootstrap.min.css
  • nikola/data/themes/bootstrap5-jinja/assets/js/bootstrap.min.js
  • nikola/data/themes/bootstrap5-jinja/assets/js/luxon.min.js
  • nikola/data/themes/bootstrap5-jinja/assets/js/popper.min.js

@dacog dacog closed this Oct 24, 2025
@dacog
Copy link
Author

dacog commented Oct 24, 2025

Hi @X1aomu ,

sorry for the late response.

All those files are mentioned in nikola/data/symlinked.txt which is generated by scripts/generate_symlinked_list.sh. And the symlinks are generated by scripts/update-npm-assets.sh

As far as I understood, that is the proper way to add those files.

Maybe someone else can provide some feedback on this matter? I can modify this and add the copies of the files, but I re-checked and the bootstrap4 themes also have the symlinks.

@dacog dacog reopened this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants