fix(native): update sentry_value_t example with 64-bit integer types
#14509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
3 tasks
Bundle ReportChanges will increase total bundle size by 1.02kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
JoshuaMoelans
commented
Jul 31, 2025
| You can add Data Attributes to both Spans and Transactions. This data is visible in the trace explorer in Sentry. | ||
| The data must be of type `sentry_value_t`, which can store: | ||
| * 32-bit signed integers, | ||
| * 64-bit signed and unsigned integers, |
There was a problem hiding this comment.
Should we mention that 64-bit unsigned values get sent as Strings until further notice? For context, see getsentry/sentry-native#1326 (comment) . Not sure how relevant this is for most users.
e.g. add something like
<Alert level="warning">
Currently, 64-bit unsigned integers are sent as strings, since they can't be processed as numerical values yet.
</Alert>
There was a problem hiding this comment.
I think it's a good idea to mention it (see below why), but I'd probably rephrase it:
* 64-bit signed integers,
* 64-bit unsigned integers (due to a current limitation, these will be converted to strings before sending),
wdyt?
why mention it at all: as we just discussed offline, data properties can be searched, and (un)signed int64 values will show up as both number (int64) and string (uint64) keys, this means that the actual user experience differs for unsigned int64 values
kahest
approved these changes
Jul 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Related to the changes in getsentry/sentry-native#1326 , we update our docs where they explicitly mention the available
sentry_value_ttypes.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: