-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(native): add structured logs documentation #15021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 11.93kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also need to update https://docs.sentry.io/product/crons/getting-started/! We're good to go after that.
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`. | ||
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this diff changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old version has a duplicate sentence at the end (This is sent from the SDK as sentry.sdk.name.
)
Looks like I removed a bit too much from the bottom one though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch!
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`. | |
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk. | |
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.version`. |
Co-authored-by: Abhijeet Prasad <[email protected]>
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`. | ||
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch!
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`. | |
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk. | |
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.version`. |
Gonna rebase this so we can try to merge it in! |
Vercel previews
Logs page https://sentry-docs-oflen3xm3.sentry.dev/platforms/native/logs/
Logs options https://sentry-docs-oflen3xm3.sentry.dev/platforms/native/configuration/options/#logs-options
DESCRIBE YOUR PR
We've finished logs for Native, so we should let people know how to use it getsentry/sentry-native#1271
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: