Skip to content

Conversation

JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Sep 23, 2025

Vercel previews
Logs page https://sentry-docs-oflen3xm3.sentry.dev/platforms/native/logs/
Logs options https://sentry-docs-oflen3xm3.sentry.dev/platforms/native/configuration/options/#logs-options

DESCRIBE YOUR PR

We've finished logs for Native, so we should let people know how to use it getsentry/sentry-native#1271

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Sep 23, 2025 7:54pm
sentry-docs Ready Ready Preview Comment Sep 23, 2025 7:54pm

@codeowner-assignment codeowner-assignment bot requested a review from a team September 23, 2025 11:01
Copy link

codecov bot commented Sep 23, 2025

Bundle Report

Changes will increase total bundle size by 11.93kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.87MB 11.94kB (0.09%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 3.98kB 829.44kB 0.48%
../app/platform-redirect/page.js.nft.json 3.98kB 829.35kB 0.48%
../app/sitemap.xml/route.js.nft.json 3.98kB 826.58kB 0.48%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/bEYH5kzWyL7P-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/bEYH5kzWyL7P-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/Wq372ncsuq3HDayw8Onrq/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/Wq372ncsuq3HDayw8Onrq/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update https://docs.sentry.io/product/crons/getting-started/! We're good to go after that.

Comment on lines 6 to 7
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`.
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this diff changed?

Copy link
Member Author

@JoshuaMoelans JoshuaMoelans Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old version has a duplicate sentence at the end (This is sent from the SDK as sentry.sdk.name.)

Looks like I removed a bit too much from the bottom one though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch!

Suggested change
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`.
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.version`.

Comment on lines 6 to 7
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`.
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch!

Suggested change
- `sdk.name`: The name of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.name`.
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.
- `sdk.version`: The version of the SDK that sent the log. This is sent from the SDK as `sentry.sdk.version`.

@AbhiPrasad
Copy link
Member

Gonna rebase this so we can try to merge it in!

@AbhiPrasad AbhiPrasad merged commit 352383d into master Sep 23, 2025
13 checks passed
@AbhiPrasad AbhiPrasad deleted the feat/native/logs branch September 23, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants