-
-
Notifications
You must be signed in to change notification settings - Fork 224
build on windows-11-arm #4187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build on windows-11-arm #4187
Conversation
I think now the only thing left is building sentry-native for Windows arm64 which is being done on: |
Downloads are separate steps because macOS (CI_PUBLISHING_BUILD) needs to download both.
Does
|
@jamescrosswell @Flash0ver On behalf of @bruno-garcia, I've fixed the remaining issues with cache keys etc. to make the CI pass. Once everything looks good, I'd propose merging this PR first, and then we can proceed with the musl PR that has some overlap. |
Just to make sure I understand what's going on here before we merge:
Is that all accurate? |
Right, we already had a Windows x64 build that the packaging build (on Mac) pulled from. So this would add a second one. |
Running a release off of this branch just to test it out: https://github.com/getsentry/sentry-dotnet/actions/runs/15174949147 cc @Flash0ver if we ship this (not planning on doing that, just want to test CI for a release build) it would take over the |
Since I tried my luck with:* getsentry/sentry-native#880Blocked by:* getsentry/sentry-native#880Not blocked because sentry-native itself compiles on arm64 on Windows, the issue there is more about setting up the repo and integration tests.
A lot was figured out by @jpnurmi when adding musl Linux, so I just copied over
TODO:
env.CI_PUBLISHING_BUILD
set totrue