-
-
Notifications
You must be signed in to change notification settings - Fork 192
chore: move xbox toolchain to sentry-xbox repository #1329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
44e6def
chore: move xbox toolchain to sentry-xbox repository
vaind 0dae6b9
update platform support docs
vaind 2f8cd89
chore: changelog
vaind abd753f
Update CHANGELOG.md
vaind c2cd959
cleanup
vaind 9a39027
keep sentry.native.xbox as sdk name
vaind 8dd3b5f
restore xbox_build.md
vaind 78fdce4
fixup: restore sentry.h properly
vaind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,3 +34,5 @@ obj/ | |
|
||
# clangd | ||
.cache | ||
|
||
sentry-native.sln |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Xbox Build Failures Due to Incorrect Variable Placement
Xbox support is broken. The new
XBOX
variable detection logic is incorrectly placed within anelseif
chain that checksCMAKE_SYSTEM_NAME
. Since Xbox builds setCMAKE_SYSTEM_NAME
to "WINDOWS", theCMAKE_GENERATOR_PLATFORM
condition for Xbox is never reached, andXBOX
is never set. This, coupled with the removal of Xbox toolchain files that generatedgdk_build.props
(a file referenced by later CMake logic whenXBOX
is true), leads to build failures for Xbox targets.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not true, there's no CMAKE_SYSTEM_NAME == windows condition in this if-elseif chain