feat: Implement the GPU Info gathering within the Native SDK #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
README.md
Outdated
| Enables GPU information collection and reporting. When enabled, the SDK will attempt to gather GPU details such as | ||
| GPU name, vendor, memory size, and driver version, which are included in event contexts. The implementation uses | ||
| platform-specific APIs: DXGI and Direct3D9 on Windows, IOKit on macOS, and PCI/DRM on Linux. Setting this to | ||
| `OFF` disables GPU information collection entirely, which can reduce dependencies and binary size. |
There was a problem hiding this comment.
Do we intend to turn this on by default at some point? Might be worth adding a note
There was a problem hiding this comment.
I rewrote it a bit, so now it will be enabled by default on all platforms that have required libraries that we can link against (DirectX, IOKit, etc. depending on the platform).
src/gpu/sentry_gpu_common.c
Outdated
| case 0x126F: | ||
| return sentry__string_clone("Silicon Motion"); | ||
| default: | ||
| return sentry__string_clone("Unknown"); |
There was a problem hiding this comment.
How about something like this so we can look at those by usage and expand?
Suggested change
| return sentry__string_clone("Unknown"); | |
| return sentry__string_clone("Unknown - " + vendor_id); |
There was a problem hiding this comment.
Good idea! Added it.
src/gpu/sentry_gpu_unix.c
Outdated
| continue; | ||
| } | ||
|
|
||
| char name_path[512]; |
There was a problem hiding this comment.
"can't ever big bigger" famous last words :)
But if it is, just truncates and then we can't find the path?
There was a problem hiding this comment.
Using MAX_PATH now ;) Nice catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.