chore: SDK Truncation Logic #1347
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1342
Truncation occurrences (‼️ List is WIP):
🔍
sentry_unwind_stack(..., max_frames)
Code here. Need to investigate if this is something we should be truncating still, or if Relay can handle this.
🔍 inproc
MAX_FRAMES
Code here and used for unwinding the stack here
Keep truncation
set_tag_n
We keep SDK-side truncation as span tags are soon to be deprecated (replaced by span attributes, which have way larger length limits (or possibly have no limited)).
code here and mention of truncation for
sentry_span_set_tag
hereremoved in (commit) but seems like this is not truncated during ingestion... docs mention that tags must be less than 200 characters

Product doesn't seem to like these large values though 😅
