Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 8, 2025

gql 4.0 changed the signature of the execute function which we were patching. Instead of a DocumentNode it now gets a GraphQLRequest (which contains the document attribute with the DocumentNode). This means we need to update the way we're extracting additional data in the event processor.

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.49%. Comparing base (5a122b5) to head (f97406c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4779      +/-   ##
==========================================
+ Coverage   84.47%   84.49%   +0.01%     
==========================================
  Files         158      158              
  Lines       16506    16513       +7     
  Branches     2865     2866       +1     
==========================================
+ Hits        13944    13952       +8     
+ Misses       1712     1709       -3     
- Partials      850      852       +2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/gql.py 84.81% <100.00%> (-1.31%) ⬇️

... and 3 files with indirect coverage changes

@sentrivana sentrivana mentioned this pull request Sep 8, 2025
@sentrivana sentrivana marked this pull request as ready for review September 12, 2025 10:36
@sentrivana sentrivana requested a review from a team as a code owner September 12, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants