Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 15, 2025

The data category for rate limiting logs is log_item, not log.

Closes #4797

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.58%. Comparing base (5747863) to head (73b3fe7).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4798      +/-   ##
==========================================
+ Coverage   84.51%   84.58%   +0.06%     
==========================================
  Files         158      158              
  Lines       16513    16513              
  Branches     2866     2866              
==========================================
+ Hits        13956    13967      +11     
+ Misses       1709     1702       -7     
+ Partials      848      844       -4     
Files with missing lines Coverage Δ
sentry_sdk/envelope.py 89.28% <100.00%> (+6.12%) ⬆️

... and 1 file with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 15, 2025 12:05
@sentrivana sentrivana requested a review from a team as a code owner September 15, 2025 12:05
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@antonpirker antonpirker merged commit 0df7f45 into master Sep 15, 2025
128 checks passed
@antonpirker antonpirker deleted the ivana/fix-log-rate-limit branch September 15, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure rate-limiting works for logs
2 participants