-
-
Notifications
You must be signed in to change notification settings - Fork 56
Update to Unity 6000.0.54f1 #2251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7a955da
to
203ae00
Compare
203ae00
to
23c9116
Compare
@@ -1,2 +1,2 @@ | |||
version = 2.50.2 | |||
version = 2.50.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dependency Downgrade Error
The sentry-cli
version was accidentally downgraded from 2.50.2 to 2.50.0, contradicting the PR's purpose of updating dependencies.
Locations (1)
fail-fast: false | ||
matrix: | ||
unity-prefix: ['2020', '2021', '2022', '6000'] | ||
unity-prefix: ['2020', '2021', '2022', '6000', '6100'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Unity Version in CI Script
The update-deps.yml
workflow now includes '6100' in its unity-prefix
matrix. However, the corresponding unity6100
case was removed from scripts/ci-env.ps1
, causing the workflow to fail with an "Unknown variable 'unity6100'" error when processing this prefix.
Locations (1)
Assert.AreEqual("image/jpeg", capturedAttachment.ContentType); | ||
Assert.AreEqual(AttachmentType.Default, capturedAttachment.Type); | ||
Assert.AreEqual(0, hint.Attachments.Count); | ||
}).Start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test Fails Due to Unjoined Background Thread
The test starts a background thread but does not wait for its completion. This creates a race condition where assertions on the background thread may not execute before the main test method finishes, leading to an unreliable test and potential false positives. The test should synchronize with the background thread, for example, by calling Thread.Join()
.
Superseded by #2255 |
#skip-changelog
Auto-generated by create-pull-request