Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

#skip-changelog

Auto-generated by create-pull-request

@bruno-garcia bruno-garcia force-pushed the chore/unity-6000.0.54f1 branch from 7a955da to 203ae00 Compare July 25, 2025 02:36
@bruno-garcia bruno-garcia force-pushed the chore/unity-6000.0.54f1 branch from 203ae00 to 23c9116 Compare July 26, 2025 02:33
@@ -1,2 +1,2 @@
version = 2.50.2
version = 2.50.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency Downgrade Error

The sentry-cli version was accidentally downgraded from 2.50.2 to 2.50.0, contradicting the PR's purpose of updating dependencies.

Locations (1)

Fix in Cursor Fix in Web

fail-fast: false
matrix:
unity-prefix: ['2020', '2021', '2022', '6000']
unity-prefix: ['2020', '2021', '2022', '6000', '6100']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Unity Version in CI Script

The update-deps.yml workflow now includes '6100' in its unity-prefix matrix. However, the corresponding unity6100 case was removed from scripts/ci-env.ps1, causing the workflow to fail with an "Unknown variable 'unity6100'" error when processing this prefix.

Locations (1)

Fix in Cursor Fix in Web

Assert.AreEqual("image/jpeg", capturedAttachment.ContentType);
Assert.AreEqual(AttachmentType.Default, capturedAttachment.Type);
Assert.AreEqual(0, hint.Attachments.Count);
}).Start();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Fails Due to Unjoined Background Thread

The test starts a background thread but does not wait for its completion. This creates a race condition where assertions on the background thread may not execute before the main test method finishes, leading to an unreliable test and potential false positives. The test should synchronize with the background thread, for example, by calling Thread.Join().

Locations (1)

Fix in Cursor Fix in Web

@bitsandfoxes
Copy link
Contributor

Superseded by #2255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants