-
-
Notifications
You must be signed in to change notification settings - Fork 57
fix: Deduplicate trace generation during startup and scene loading #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sentry review |
@sentry review |
mujacica
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2235
Note: The flow differs from Editor vs actual build since not all RuntimeInitialization attributes get triggered.
In an actual build this is now the flow:
RuntimeInitialization SubsystemRegistration
sentry-unity/package-dev/Runtime/SentryInitialization.cs
Line 68 in dbbb63c
SentryUnitySdk
initializes the .NET SDKsentry-unity/src/Sentry.Unity/SentryUnitySdk.cs
Line 38 in dbbb63c
TraceGenerationIntegration
refrains from regenerating any traces that would be covered by other integrationsStartupTracingIntegration
creates a transaction and it's child spanssentry-unity/src/Sentry.Unity/SentryUnitySdk.cs
Line 42 in dbbb63c
SceneManagerAPI
.StartupTracing
andSceneManagerTracing
SceneManagerTracingIntegration
is solely responsible for generating a transaction. Finishing the transaction generates a new trace implicitely.