chore: Remove deprecated runtime/build time configuration #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bitsandfoxes
commented
Sep 29, 2025
| <WindowsNativeSupportEnabled>k__BackingField: 1 | ||
| <MacosNativeSupportEnabled>k__BackingField: 1 | ||
| <LinuxNativeSupportEnabled>k__BackingField: 1 | ||
| <XboxNativeSupportEnabled>k__BackingField: 1 |
There was a problem hiding this comment.
Missed checking this in to the samples when adding Xbox support.
bitsandfoxes
commented
Sep 29, 2025
| AndroidNativeSupportEnabled = AndroidNativeSupportEnabled, | ||
| NdkIntegrationEnabled = NdkIntegrationEnabled, | ||
| NdkScopeSyncEnabled = NdkScopeSyncEnabled, | ||
| PostGenerateGradleProjectCallbackOrder = PostGenerateGradleProjectCallbackOrder, |
There was a problem hiding this comment.
This was previously wrongly only on the scriptable object and not on the actual options, making them inaccessible programmatically.
mujacica
approved these changes
Sep 30, 2025
bitsandfoxes
deleted the
chore/remove-deprecated-runtime-buildtime-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in #1888 replaced the runtime/build time configuration setup into one
Option Configurationsetup. The same callback would get invoked wether it is on runtime or at build time.We kept the old setup around as to not break people when upgrading but it's been 2 mayor releases now.
A migration guide is already in place: https://docs.sentry.io/platforms/unity/migration/#changes-to-the-programmatic-configuration.