chore(issue detection): start removal of suspect-commit-strategy option #98312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cvxluo
approved these changes
Aug 26, 2025
| @@ -3466,7 +3466,7 @@ | |||
| register( | |||
| "issues.suspect-commit-strategy", | |||
| type=Bool, | |||
| default=False, | |||
| default=True, | |||
There was a problem hiding this comment.
for future ref, i don't think you need to change this to True in this PR — the ordering would go:
- remove all usage of option
- remove from options automator
- remove registration here
There was a problem hiding this comment.
oh you're right, i think i interpreted the first bullet of the docs incorrectly, thought it was saying that you had to https://github.com/getsentry/sentry-options-automator?tab=readme-ov-file#deleting-an-option
kenzoengineer
pushed a commit
that referenced
this pull request
Aug 28, 2025
…on (#98312) Feature is working - let's remove the option corresponding piece getsentry/sentry-options-automator#4992
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 28, 2025
…on (#98312) Feature is working - let's remove the option corresponding piece getsentry/sentry-options-automator#4992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature is working - let's remove the option
corresponding piece https://github.com/getsentry/sentry-options-automator/pull/4992