Skip to content

fix(test): thread leak allowlist: ingest consumers #98316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(test): thread leak allowlist: ingest consumers #98316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd58309
thread leak allowlist: ingest consumers
kenzoengineer Aug 26, 2025
0ae9bd4
Merge branch 'master' into kenjiang/ingest-473-thread-leak-in-test-in…
kenzoengineer Aug 28, 2025
9fcc468
thread leak allowlist method signature update
kenzoengineer Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/sentry/ingest/ingest_consumer/test_ingest_consumer_kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,15 @@
from sentry.services.eventstore.processing import event_processing_store
from sentry.testutils.pytest.fixtures import django_db_all
from sentry.testutils.skips import requires_kafka, requires_snuba
from sentry.testutils.thread_leaks.pytest import thread_leak_allowlist
from sentry.utils.batching_kafka_consumer import create_topics
from sentry.utils.kafka_config import get_topic_definition

pytestmark = [requires_snuba, requires_kafka]
pytestmark = [
requires_snuba,
requires_kafka,
thread_leak_allowlist(reason="ingest consumers", issue=97037),
]

logger = logging.getLogger(__name__)

Expand Down
2 changes: 2 additions & 0 deletions tests/sentry/ingest/ingest_consumer/test_ingest_consumer_transactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from sentry.services import eventstore
from sentry.testutils.pytest.fixtures import django_db_all
from sentry.testutils.skips import requires_kafka, requires_snuba
from sentry.testutils.thread_leaks.pytest import thread_leak_allowlist
from sentry.utils.batching_kafka_consumer import create_topics
from sentry.utils.kafka_config import get_topic_definition

Expand Down Expand Up @@ -71,6 +72,7 @@ def random_group_id() -> str:

@django_db_all(transaction=True)
@pytest.mark.parametrize("no_celery_mode", [True, False])
@thread_leak_allowlist(reason="ingest consumers", issue=97037)
def test_ingest_consumer_reads_from_topic_and_saves_event(
no_celery_mode,
task_runner,
Expand Down
Loading