feat(onboarding): Simplify Node AWS Lambda onboarding docs #98348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| }, | ||
| } satisfies BasePlatformOptions; | ||
|
|
||
| type PlatformOptions = typeof platformOptions; | ||
| type Params = DocsParams<PlatformOptions>; | ||
|
|
||
| const getEnvSetupSnippet = (params: Params) => ` | ||
| NODE_OPTIONS="-r @sentry/aws-serverless/awslambda-auto" | ||
| NODE_OPTIONS="--import @sentry/aws-serverless/awslambda-auto" |
There was a problem hiding this comment.
Bug: Lambda Auto-Instrumentation Fails with ES Module Flag
The NODE_OPTIONS flag changed from -r to --import. Since --import is specific to ES Modules and -r works for both CommonJS and ES Modules, this change could prevent auto-instrumentation from loading correctly in existing CommonJS AWS Lambda functions, potentially causing them to fail.
There was a problem hiding this comment.
--import works correctly for both
kenzoengineer
pushed a commit
that referenced
this pull request
Aug 28, 2025
Simplifies and refactors the Node AWS Lambda onboarding docs to reflect that: - The Lambda layer supports both ESM and CJS, no need to differentiate based on this anymore - The SDK supports automatic wrapping for both ESM and CJS, no need to show manual setup in onboarding anymore closes https://linear.app/getsentry/issue/FE-592/update-aws-onboarding-docs
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 28, 2025
Simplifies and refactors the Node AWS Lambda onboarding docs to reflect that: - The Lambda layer supports both ESM and CJS, no need to differentiate based on this anymore - The SDK supports automatic wrapping for both ESM and CJS, no need to show manual setup in onboarding anymore closes https://linear.app/getsentry/issue/FE-592/update-aws-onboarding-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies and refactors the Node AWS Lambda onboarding docs to reflect that:
closes https://linear.app/getsentry/issue/FE-592/update-aws-onboarding-docs