Check new commits for yes/no in package.yml

[androidnisse]

Summary

• Add checks for yes/no in package.yml.
• Resolves Check new commits for yes/no in package.yml #6346

Test Plan

• Added yes to a package.yml and tested with the new checks.

Checklist

• Package was built and tested against unstable
• This change could gainfully be listed in the weekly sync notes once merged

[androidnisse]

Made by the help of copy paste and ChatGPT so please double check it.

[joebonrichie]

What happens if you put yes/no in the summary or description?

[androidnisse]

What happens if you put yes/no in the summary or description?

It lets you push. This looks for : yes or : no so it needs the colon as well. But yes if a summary has : yes in it that would get an error.

Or as chatgpt would say

That regex only matches if the string ends with : yes or : no (with optional spaces, case-insensitive). It won’t match a stray “yes” or “no” elsewhere in the text.

[EbonJaeger]

Could you please fix the issues that flake8 complains about? They appear to just be stylistic:

• common/CI/package_checks.py:422:1: E302 expected 2 blank lines, found 1
• common/CI/package_checks.py:434:27: E111 indentation is not a multiple of 4
• common/CI/package_checks.py:434:27: E117 over-indented
• common/CI/package_checks.py:443:1: E302 expected 2 blank lines, found 1

[androidnisse]

Could you please fix the issues that flake8 complains about? They appear to just be stylistic:

* `common/CI/package_checks.py:422:1: E302 expected 2 blank lines, found 1`

* `common/CI/package_checks.py:434:27: E111 indentation is not a multiple of 4`

* `common/CI/package_checks.py:434:27: E117 over-indented`

* `common/CI/package_checks.py:443:1: E302 expected 2 blank lines, found 1`

Now it all looks green.

[EbonJaeger]

LGTM, thanks!