-
Notifications
You must be signed in to change notification settings - Fork 13.1k
vulkan: automatically remove unsupported devices #15976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, but I would prefer it during the device selection, instead of removing devices afterwards. I can also do the implementation if you prefer that.
Ok this should do it. I got rid of the warning message as well as I don't really see the point of that here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise. I don't have a device to test this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* remove unsupported vulkan devices * make this happen during selection instead * pass by reference
This basically gets rid of any unsupported devices early on to avoid a crash as my Intel integrated chip with no 16 bit storage got enabled by #15947.
Before:
After: