ggml: add FLOOR unary op (CPU + SYCL) #15989
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
FLOOR
unary operator to ggml, with implementations for both CPU and SYCL backends.Details
GGML_UNARY_OP_FLOOR
toggml_unary_op
enum and updated operator name table.unary-ops.impl.h
.element_wise.cpp
and dispatch inggml-sycl.cpp
.ggml_backend_sycl_device_supports_op
to allowFLOOR
.Testing
-DGGML_SYCL=ON -DLLAMA_BUILD_TESTS=ON
.ctest --output-on-failure
: all relevant unary tests passed on CPU and SYCL (f32).FLOOR
outputs vs. CPU reference implementation.Notes
f16
support on SYCL GPUs may depend on driver/device capabilities (currently not supported on some Intel GPUs).f32
works as expected across backends.