server: added support for systemd socket activation and readiness reporting #15998
+115
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert the formatting commit. Any formatting that affect the whole file should be done in a dedicated PR. |
pvaret
force-pushed
the
systemd-support
branch
from
96eb851 to
537d368
Compare
|
Sure -- done! Thanks for the advice. Should I re-submit the formatting commit as a separate PR, or is that just not considered very valuable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command line flag to llama-server,
--systemd, that makes it:This allows running llama-server as a systemd service, with on-demand activation, and reliable readiness reporting.
This PR makes use of macros to ensure that the systemd-related code is only built if the build is configured with
-DLLAMA_SERVER_SYSTEMD=ON.Per CONTRIBUTING.md, the modified files were formatted with clang-format. The formatting was applied in a distinct commit for easier reviewing.