fix : Dangling pointer for non-empty trigger words in lazy grammar construction #17048
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-hradil
changed the title
Member
|
Yes, looks like a bug. But adding I think that simply keeping |
Author
|
@ggerganov that makes much more sense. I've edited that, can you have a look if it looks better now? |
ggerganov
previously approved these changes
Nov 6, 2025
Green-Sky
suggested changes
Nov 6, 2025
| trigger_pattern += ")[\\s\\S]*"; | ||
| const auto * trigger_pattern_c = trigger_pattern.c_str(); | ||
| trigger_pattern_c = trigger_pattern.c_str(); | ||
| trigger_patterns = &trigger_pattern_c; |
Collaborator
There was a problem hiding this comment.
This is still a dangling pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix on issue #17047.
Added
statickeyword, to not let the pointer be out of scope. However, my understanding of this functionality in cpp is poor, so happy to be corrected with some better engineering.To consider: Isn't
staticalso needed on line 1631, when constructingtrigger_pattern?