-
Notifications
You must be signed in to change notification settings - Fork 13.6k
cmake: add option to build and link BoringSSL #17062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
cmake: add option to build and link BoringSSL #17062
Conversation
This commit adds an easy way to fetch, build, and statically link the BoringSSL library when LLAMA_BUILD_BORINGSSL is enabled. The version can be set via the LLAMA_BORINGSSL_VERSION cache variable. Signed-off-by: Adrien Gallouët <[email protected]>
|
Few observations:
|
As a quick fix, I can support
Yes, my plan is to progressively remove |
Signed-off-by: Adrien Gallouët <[email protected]>
| option(LLAMA_LLGUIDANCE "llama-common: include LLGuidance library for structured output in common utils" OFF) | ||
| option(LLAMA_CURL "llama: use libcurl to download model from an URL" ON) | ||
| option(LLAMA_OPENSSL "llama: use openssl to support HTTPS" OFF) | ||
| option(LLAMA_BUILD_BORINGSSL "llama: build and statically link BoringSSL" OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to call this LLAMA_BUILD_BORINGSSL instead of the more consistent LLAMA_BORINGSSL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to emphasize that we don’t just use BoringSSL (like we use OpenSSL with LLAMA_OPENSSL), but actually build it. But we can definitely use LLAMA_BORINGSSL.
Also, I think we can simply use BORINGSSL_VERSION to specify the version?
Signed-off-by: Adrien Gallouët <[email protected]>
|
Quick heads up, BoringSSL does not support the s390x platform due to endianness issues. So if possible for CI tests, exclude s390x from the BoringSSL tests. |
Signed-off-by: Adrien Gallouët <[email protected]>
This commit adds an easy way to fetch, build, and statically link the BoringSSL library when LLAMA_BUILD_BORINGSSL is enabled.
The version can be set via the LLAMA_BORINGSSL_VERSION cache variable.