vulkan: fuse mul_mat_id + mul #17095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
Collaborator
|
Please fix the conflict. |
This comes up in qwen3 moe.
jeffbolznv
force-pushed
the
mul_mat_id_mul
branch
from
4f922ce to
20a4ec2
Compare
Collaborator
Author
|
Rebased. |
slaren
reviewed
Nov 8, 2025
Comment on lines
+3619
to
+3624
| if (mul) { | ||
| std::array<int64_t, 4> ne { 1, out->ne[1], out->ne[2], out->ne[3] }; | ||
| ne[0] = 1; | ||
| ggml_tensor * m = ggml_new_tensor(ctx, out->type, 4, ne.data()); | ||
| out = ggml_mul(ctx, out, m); | ||
| } |
Member
There was a problem hiding this comment.
I really don't like how we keep making the basic, single op test cases more complex by adding flags to change the behavior completely. Can you move the fusion cases to a different class?
slaren
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes up in qwen3 moe. Worth 1-2% on Qwen3 MoE.
I'd eventually like to generalize this, to be able to handle things like MUL_MAT_ID + ADD_ID + MUL (which comes up in gpt-oss).