Make executable bits additive with symlink/submodule priority in file icons #10226
+191
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, executable files showed a separate "Ex" badge alongside the file icon, which didn't integrate well with the visual design. This change makes executable indicators additive by overlaying a small "x" badge on the base file icon, while ensuring symlinks and submodules always display their specific icons regardless of executable status.
Changes
File Icon System Overhaul:
fileType
prop toFileIcon
,FileName
,FileListItem
, andFileViewHeader
componentsfileTypeUtils.ts
with functions to determine file types fromTreeChange
objectsExecutableLabel
component in favor of integrated overlayIcon Behavior:
Backend Integration:
FileList
andFileListItemWrapper
to detect file types fromChangeState.kind
executable
propBlob
,BlobExecutable
,Link
,Commit
Visual Result
The new system provides a cleaner, more integrated approach where:
This addresses the issue where executable files should have their base icon with an executable indicator, while ensuring symlinks and submodules always look like what they are regardless of their executable status.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.