Skip to content

Conversation

SilkePilon
Copy link
Contributor

Move to a borderless textarea wrapper and add maxRows so the input can grow up to 8 lines before scrolling. Constrain the input container with overflow hidden and a fixed bottom padding to make space for action buttons. Add a semi-opaque fade overlay at the bottom to visually mask the scroll boundary, and place the action toolbar above the fade using z-index so buttons remain accessible. Also add a subtle border, radius, and background to match other dialogs.

Move to a borderless textarea wrapper and add maxRows so the input can
grow up to 8 lines before scrolling. Constrain the input container with
overflow hidden and a fixed bottom padding to make space for action
buttons. Add a semi-opaque fade overlay at the bottom to visually mask
the scroll boundary, and place the action toolbar above the fade using
z-index so buttons remain accessible. Also add a subtle border, radius,
and background to match other dialogs.
Copy link

vercel bot commented Sep 12, 2025

@SilkePilon is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@SilkePilon
Copy link
Contributor Author

SilkePilon commented Sep 12, 2025

Preview:

Recording.2025-09-12.151426.mp4

I also changed the border radius to be the same as the other ui elements, tho this can be reverted

@krlvi
Copy link
Member

krlvi commented Sep 12, 2025

Thank you very much for the fix.
Just a thought about the fade - Wouldn't it make more sense to fade the top of text when it's out of view instead of the bottom?
@PavelLaptev if you remember, we had this fade for the commit message box, but at some point we realized that it was incontinent when typing to not see the characters that you just typed

@krlvi krlvi requested a review from PavelLaptev September 12, 2025 13:29
@PavelLaptev
Copy link
Contributor

@PavelLaptev if you remember, we had this fade for the commit message box, but at some point we realized that it was incontinent when typing to not see the characters that you just typed

That was a different issue. It was always on the right and blocked the text.

@PavelLaptev
Copy link
Contributor

@SilkePilon I'll make some changes

- smaller gradient height
- smaller border radius
@PavelLaptev
Copy link
Contributor

PavelLaptev commented Sep 12, 2025

Changes:

  • The inner radius has been reduced.
image
  • The bottom padding has been reduced. The gradient scale appears less appealing when the scale is longer, but the bottom padding was too large.
image

@PavelLaptev
Copy link
Contributor

@SilkePilon I can merge it if you okay with these changes

@SilkePilon
Copy link
Contributor Author

👍 Looks good to me!

@krlvi krlvi enabled auto-merge September 12, 2025 13:52
@krlvi krlvi merged commit c94977b into gitbutlerapp:master Sep 12, 2025
18 of 19 checks passed
@SilkePilon SilkePilon deleted the feat/ui-scrollable-codegen-input branch September 12, 2025 13:56
@PavelLaptev
Copy link
Contributor

PavelLaptev commented Sep 12, 2025

@krlvi @SilkePilon there is an issue with the scrollbar

image image

This could mean that we need to treat the input differently, avoiding the use of inner textarea padding. I’ll address this in the next PR. I see if I can save this nice gradient without adding extra JS logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants