Skip to content

Update development instructions and guidelines #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 3, 2025

Conversation

jamesmontemagno
Copy link
Contributor

@jamesmontemagno jamesmontemagno commented Jul 2, 2025

Documentation Updates:

  • Updated the "Custom Chat Modes" section in README.md to reflect corrected file links and descriptions, such as renaming Database Administrator Chat Mode file to postgresql-dba.chatmode.md.
  • Adjusted the description of "Custom Chat Modes" in README.md to use consistent iconography, replacing 🎭 with 🧩.

Instruction File Renaming and Enhancements:

  • Renamed and updated instruction files to use .instructions.md extensions for clarity (e.g., angular.md to angular.instructions.md). Added applyTo fields to specify applicable file types, such as **/*.ts for Angular instructions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Improved descriptions for instruction files by enclosing them in single quotes for consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Chat Mode Updates:

  • Adjusted the description fields in debug.chatmode.md and planner.chatmode.md to use single quotes for consistency. [1] [2]

These changes improve the organization, clarity, and usability of the documentation and configuration files, making them more consistent and easier to maintain.

…ython; add comprehensive guidelines for PostgreSQL DBA, Angular, ASP.NET REST APIs, Azure Functions with TypeScript, Bicep, Blazor, CMake with vcpkg, C#, .NET MAUI, GenAIScript, Terraform for Azure, localization, and markdown standards.
@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 22:19
Copilot

This comment was marked as outdated.

- Standardized description formatting in various markdown files to use single quotes.
- Added error handling utility in update-readme.js for safer file operations.
- Improved title extraction logic in update-readme.js to handle frontmatter more robustly.
- Updated chat modes section in README to reflect new emoji and sorted chat mode links.
- Cleaned up various instruction files for better readability and consistency.
- Ensured all markdown files end with a newline for better compatibility with version control.
@aaronpowell aaronpowell requested a review from Copilot July 2, 2025 23:36
Copilot

This comment was marked as outdated.

Copy link
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm onboard with the change to the file name for chat mode files, as they are what is the mode selector in VS Code, so now we have less human readable modes

Copilot

This comment was marked as outdated.

@aaronpowell aaronpowell requested a review from Copilot July 3, 2025 01:17
@aaronpowell aaronpowell merged commit 6fb794b into github:main Jul 3, 2025
1 check passed
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the README generation script and standardizes documentation across instruction, prompt, and chat mode files.

  • Refactored update-readme.js to use templated sections and safe file operations
  • Renamed instruction files to .instructions.md, added applyTo fields, and unified frontmatter formatting
  • Updated frontmatter quoting in prompt and chat mode files and fixed broken links/icons in README.md

Reviewed Changes

Copilot reviewed 34 out of 39 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
update-readme.js Introduces templating constants, safe file operations, and separate generators for sections
README.md Swaps the custom chat mode icon, and updates links to the renamed .instructions.md files
prompts/javascript-typescript-jest.prompt.md Converts frontmatter to single-quoted values for consistency
instructions/python.instructions.md Renames extension and adds an applyTo field to specify applicable file patterns
chatmodes/postgresql-dba.chatmode.md Renames the chat mode, adds the extensions tool, and improves the description on using the plugin
Comments suppressed due to low confidence (2)

README.md:56

  • [nitpick] The display name 'Javascript Typescript Jest' should be formatted consistently as 'JavaScript/TypeScript Jest' to match standard naming conventions.
- [Javascript Typescript Jest](prompts/javascript-typescript-jest.prompt.md) - Best practices for writing JavaScript/TypeScript tests using Jest, including mocking strategies, test structure, and common patterns.

update-readme.js:270

  • The variable link is not defined in generateInstructionsSection, causing URLs to be undefined. Introduce const link = encodeURI(instructions/${file}); before using it.
      instructionsContent += `- [${title}](${link}) - ${customDescription}\n`;

/**
* Generate the prompts section with an alphabetical list of all prompts
*/
function generatePromptsSection(promptsDir) {
Copy link
Preview

Copilot AI Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The three section-generation functions share very similar logic. Consider abstracting the common listing pattern into a reusable helper to reduce duplication and simplify future updates.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants