Bundle Actions using esbuild

.github/dependabot.yml

@@ -5,7 +5,7 @@ updates:
     schedule:
       interval: weekly
     labels:
-      - Update dependencies
+      - Rebuild
     # Ignore incompatible dependency updates
     ignore:
       # There is a type incompatibility issue between v0.0.9 and our other dependencies.

.github/update-release-branch.py

@@ -97,8 +97,8 @@ def open_pr(
   body.append(' - [ ] Ensure the docs team is aware of any documentation changes that need to be released.')
 
   if not is_primary_release:
-    body.append(' - [ ] Remove and re-add the "Update dependencies" label to the PR to trigger just this workflow.')
-    body.append(' - [ ] Wait for the "Update dependencies" workflow to push a commit updating the dependencies.')
+    body.append(' - [ ] Remove and re-add the "Rebuild" label to the PR to trigger just this workflow.')
+    body.append(' - [ ] Wait for the "Rebuild" workflow to push a commit updating the distribution files.')
 
   body.append(' - [ ] Mark the PR as ready for review to trigger the full set of PR checks.')
   body.append(' - [ ] Approve and merge this PR. Make sure `Create a merge commit` is selected rather than `Squash and merge` or `Rebase and merge`.')
@@ -108,7 +108,7 @@ def open_pr(
     body.append(' - [ ] Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.')
 
   title = f'Merge {source_branch} into {target_branch}'
-  labels = ['Update dependencies'] if not is_primary_release else []
+  labels = ['Rebuild'] if not is_primary_release else []
 
   # Create the pull request
   # PR checks won't be triggered on PRs created by Actions. Therefore mark the PR as draft so that
@@ -389,7 +389,7 @@ def main():
 
     # Migrate the package version number from a vLatest version number to a vOlder version number
     print(f'Setting version number to {version} in package.json')
-    replace_version_package_json(get_current_version(), version) # We rely on the `Update dependencies` workflow to update package-lock.json
+    replace_version_package_json(get_current_version(), version) # We rely on the `Rebuild` workflow to update package-lock.json
     run_git('add', 'package.json')
 
     # Migrate the changelog notes from vLatest version numbers to vOlder version numbers

.github/workflows/post-release-mergeback.yml

@@ -3,7 +3,7 @@
 #    tag
 # 2. Updates the `vN` tag to refer to this merge commit.
 # 3. Iff vN == vLatest, merges any changes from the release back into the main branch.
-#    Typically, this is two commits – one to update the version number and one to update dependencies.
+#    Typically, this is two commits – one to update the version number and one to rebuild.
 name: Tag release and merge back
 
 on:
@@ -138,8 +138,8 @@ jobs:
 
             Please do the following:
 
-            - [ ] Remove and re-add the "Update dependencies" label to the PR to trigger just this workflow.
-            - [ ] Wait for the "Update dependencies" workflow to push a commit updating the dependencies.
+            - [ ] Remove and re-add the "Rebuild" label to the PR to trigger just this workflow.
+            - [ ] Wait for the "Rebuild" workflow to push a commit updating the distribution files.
             - [ ] Mark the PR as ready for review to trigger the full set of PR checks.
             - [ ] Approve and merge the PR. When merging the PR, make sure "Create a merge commit" is
                   selected rather than "Squash and merge" or "Rebase and merge".
@@ -162,7 +162,7 @@ jobs:
             --head "${NEW_BRANCH}" \
             --base "${BASE_BRANCH}" \
             --title "${pr_title}" \
-            --label "Update dependencies" \
+            --label "Rebuild" \
             --body "${pr_body}" \
             --assignee "${GITHUB_ACTOR}" \
             --draft

.github/workflows/pr-checks.yml

@@ -9,89 +9,58 @@ on:
   workflow_dispatch:
 
 jobs:
-  check-js:
-    name: Check JS
-    runs-on: ubuntu-latest
-    timeout-minutes: 45
-    permissions:
-      contents: read
-      security-events: write # needed to upload ESLint results
-
+  unit-tests:
+    name: Unit Tests
     strategy:
       fail-fast: false
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
-
-      - name: Lint
-        id: lint
-        run: npm run-script lint-ci
-
-      - name: Upload sarif
-        uses: github/codeql-action/upload-sarif@v3
-        with:
-          sarif_file: eslint.sarif
-          category: eslint
-
-      - name: Check generated JS
-        run: .github/workflows/script/check-js.sh
-
-  check-node-modules:
-    if: github.event_name != 'push' || github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases/v')
-    name: Check modules up to date
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
     permissions:
       contents: read
-    runs-on: macos-latest
+      security-events: write # needed to upload ESLint results
+    runs-on: ${{ matrix.os }}
     timeout-minutes: 45
 
     steps:
       - uses: actions/checkout@v5
-      - name: Check node modules up to date
-        run: .github/workflows/script/check-node-modules.sh
-
-  check-file-contents:
-    if: github.event_name != 'push' || github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases/v')
-    name: Check file contents
-    permissions:
-      contents: read
-    runs-on: ubuntu-latest
-    timeout-minutes: 45
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20.x'
+          cache: 'npm'
 
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: 3.11
 
-      # Ensure the generated PR check workflows are up to date.
+      - name: Install dependencies
+        run: |
+          # Use the system Bash shell to ensure we can run commands like `npm install`
+          # that are not available in the default shell on Windows.
+          npm config set script-shell bash
+          npm install
+
+      - name: Verify compiled JS up to date
+        run: .github/workflows/script/check-js.sh
+
       - name: Verify PR checks up to date
         run: .github/workflows/script/verify-pr-checks.sh
 
-  npm-test:
-    if: github.event_name != 'push' || github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/releases/v')
-    name: Unit Test
-    needs: [check-js, check-node-modules]
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
-    permissions:
-      contents: read
-    runs-on: ${{ matrix.os }}
-    timeout-minutes: 45
+      - name: Run unit tests
+        run: npm test
 
-    steps:
-      - uses: actions/checkout@v5
-      - name: npm test
-        run: |
-          # Run any commands referenced in package.json using Bash, otherwise
-          # we won't be able to find them on Windows.
-          npm config set script-shell bash
-          npm test
+      - name: Lint
+        if: matrix.os != 'windows-latest'
+        run: npm run lint-ci
+
+      - name: Upload sarif
+        uses: github/codeql-action/upload-sarif@v3
+        if: matrix.os == 'ubuntu-latest'
+        with:
+          sarif_file: eslint.sarif
+          category: eslint
 
   check-node-version:
     if: github.event.pull_request

.gitignore

@@ -1,5 +1,7 @@
-# Ignore for example failing-tests.json from AVA
-node_modules/.cache/
+# Dependency directories
+node_modules/
+# Build output for tests
+lib-test/
 # Java build files
 .gradle/
 *.class
@@ -8,4 +10,4 @@ node_modules/.cache/
 # eslint sarif report
 eslint.sarif
 # for local incremental compilation
-tsconfig.tsbuildinfo
+tsconfig.tsbuildinfo

.vscode/settings.json

@@ -6,6 +6,7 @@
 
     // transpiled JavaScript
     "lib": true,
+    "lib-test": true,
   },
   // Installing a new Node package often triggers VS Code's git limit warnings as there is typically
   // an intermediate stage where many files are modified. This setting suppresses these warnings.

build.mjs

@@ -0,0 +1,46 @@
+import { rm } from "node:fs/promises";
+import path, { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
+
+import * as esbuild from "esbuild";
+import { globSync } from "glob";
+import { copy } from "esbuild-plugin-copy";
+import { typecheckPlugin } from "@jgoz/esbuild-plugin-typecheck";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+const OUT_DIR = "lib";
+
+await rm(join(__dirname, OUT_DIR), { recursive: true, force: true });
+
+// This will just log when a build ends
+/** @type {esbuild.Plugin} */
+const onEndPlugin = {
+  name: "on-end",
+  setup(build) {
+    build.onEnd((result) => {
+      // eslint-disable-next-line no-console
+      console.log(`Build ended with ${result.errors.length} errors`);
+    });
+  },
+};
+
+const copyDefaults = copy({
+  assets: {
+    from: ["src/defaults.json"],
+    to: ["defaults.json"],
+  },
+});
+
+const context = await esbuild.context({
+  entryPoints: globSync(["src/*-action.ts", "src/*-action-post.ts"]),
+  bundle: true,
+  format: "cjs",
+  outdir: OUT_DIR,
+  platform: "node",
+  plugins: [typecheckPlugin(), copyDefaults, onEndPlugin],
+});
+
+await context.rebuild();
+await context.dispose();

eslint.config.mjs

@@ -27,8 +27,10 @@ export default [
     ignores: [
       "**/webpack.config.js",
       "lib/**/*",
+      "lib-test/**/*",
       "src/testdata/**/*",
       "tests/**/*",
+      "build.mjs",
       "eslint.config.mjs",
       ".github/**/*",
     ],