Bazel: do not force lld and fix platforms warning
#20250
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was meant to avoid using `gold`, but `lld` might not be installed. Having `gold` installed results in the following warning: ``` warning: the gold linker is deprecated and has known bugs with Rust | = help: consider using LLD or ld from GNU binutils instead ``` * if a user sees this warning, they can provide the `lld` or whatever linker they prefer themselves, or make sure to uninstall `gold` * in any case, this is not what we use for releasing (where we are sure we don't use `gold`).
There was a problem hiding this comment.
Pull Request Overview
This PR removes the forced use of the lld linker in Bazel builds and updates the platforms dependency to resolve warnings. The changes address two issues: avoiding forced lld linker usage (which may not be installed) and eliminating a platforms version warning.
Key changes:
- Removes hardcoded
lldlinker configuration from.bazelrc - Updates platforms dependency from version 0.0.11 to 1.0.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MODULE.bazel | Updates platforms dependency to version 1.0.0 to resolve deprecation warning |
| .bazelrc | Removes forced lld linker configuration for Linux and macOS builds |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to avoid using
gold, butlldmight not be installed. Havinggoldinstalled results in the following warning:lldor whatever linker they prefer themselves, or make sure to uninstallgoldgold).