rust integration test: use all output from codeql test run #20269
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration test expectes to find a certain phrase from the extractor repeated in the _stderr_ of `codeql test run`. However, that subcommand is about to start reproducing the extractor output as-is, which means the phrase will instead appear in _stdout_. Change the integration test to capture all of the output, so it will keep passing across the change.
There was a problem hiding this comment.
Pull Request Overview
This PR updates a Rust integration test to capture all output from codeql test run instead of only stderr, preparing for an upcoming change where extractor output will be reproduced to stdout rather than stderr.
- Changes the
_captureparameter from "stderr" to "all" in the failing cargo check test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test expectes to find a certain phrase from the extractor repeated in the stderr of
codeql test run. However, that subcommand is about to start reproducing the extractor output as-is, which means the phrase will instead appear in stdout.Change the integration test to capture all of the output, so it will keep passing across the change.