Skip to content

Increase mysql backend timeout to 2s #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Increase mysql backend timeout to 2s #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8a4646
update mysql backend timeout
meiji163 Mar 19, 2025
8b7ffe5
fix test
meiji163 Mar 19, 2025
d20f1a1
increase election timeout to 2s
meiji163 Mar 22, 2025
d9dfc35
client timeout 2s
meiji163 Mar 22, 2025
caa7bbb
fix test again
meiji163 Mar 22, 2025
d54c858
increase timeout and election expiration
meiji163 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/group/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ type MySQLBackend struct {
}

const maxConnections = 3
const electionExpireSeconds = 5
const electionExpireSeconds = 10

const electionInterval = time.Second
const electionInterval = 2 * time.Second
const healthInterval = 2 * electionInterval
const stateInterval = 10 * time.Second

Expand Down Expand Up @@ -113,7 +113,7 @@ func getBackendDBUri() string {
// Set collation instead of charset, if BackendMySQLCollation is specified
dsnCharsetCollation = fmt.Sprintf("collation=%s", config.Settings().BackendMySQLCollation)
}
return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?interpolateParams=true&%s&timeout=500ms",
return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?interpolateParams=true&%s&timeout=8s",
config.Settings().BackendMySQLUser,
config.Settings().BackendMySQLPassword,
config.Settings().BackendMySQLHost,
Expand Down
4 changes: 2 additions & 2 deletions pkg/group/mysql_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ func TestGetBackendDBUri(t *testing.T) {

// test default (charset)
dbUri := getBackendDBUri()
test.S(t).ExpectEquals(dbUri, "gromit:penguin@tcp(myhost:3306)/test_database?interpolateParams=true&charset=utf8mb4,utf8,latin1&timeout=500ms")
test.S(t).ExpectEquals(dbUri, "gromit:penguin@tcp(myhost:3306)/test_database?interpolateParams=true&charset=utf8mb4,utf8,latin1&timeout=8s")

// test setting collation
config.Settings().BackendMySQLCollation = "utf8mb4_unicode_ci"
dbUri = getBackendDBUri()
test.S(t).ExpectEquals(dbUri, "gromit:penguin@tcp(myhost:3306)/test_database?interpolateParams=true&collation=utf8mb4_unicode_ci&timeout=500ms")
test.S(t).ExpectEquals(dbUri, "gromit:penguin@tcp(myhost:3306)/test_database?interpolateParams=true&collation=utf8mb4_unicode_ci&timeout=8s")
}
Loading