-
Notifications
You must be signed in to change notification settings - Fork 80
fix: Status and Created At column header/data alignment issue #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@zkoppert 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: zkoppert <[email protected]>
Status
and Created At
@copilot can you fix the failing GitHub actions on this pull request? |
- Fixed line length violations by splitting long lines - Moved import to top level to avoid import-outside-toplevel error - Fixed trailing whitespace and formatting issues - Added final newline to meet linting requirements All 114 tests continue to pass with 91% coverage. Co-authored-by: zkoppert <[email protected]>
Fixed the failing GitHub Actions. The issue was linting errors in the test file including line length violations, import placement, and formatting issues. All problems have been resolved in commit f0395d6. All 114 tests now pass with 91% coverage and linting is clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a column header/data alignment issue where the Status and Created At columns were displaying swapped data in markdown output. The problem occurred when both HIDE_STATUS
and HIDE_CREATED_AT
were set to false
, causing status values to appear in the Created At column and vice versa.
Key changes:
- Reordered column definitions in
get_non_hidden_columns()
to match the data writing sequence inwrite_to_markdown()
- Updated existing tests to reflect the correct column order
- Added comprehensive test coverage to verify the Status and Created At columns contain appropriate data types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
markdown_writer.py | Moved Status column definition after Created At column to align with data writing order |
test_markdown_writer.py | Updated expected column headers in test assertions to match new correct order |
test_column_order_fix.py | Added new test file with focused test cases to verify Status and Created At columns alignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
The Status and Created At columns in the markdown output were displaying swapped data due to a mismatch between column header ordering and data writing logic.
Problem
When
HIDE_STATUS
andHIDE_CREATED_AT
were both set tofalse
, the generated table showed:This occurred because the column headers were defined in one order while the actual data was written in a different order.
Root Cause
In
markdown_writer.py
, theget_non_hidden_columns()
function defined columns in this order:But the
write_to_markdown()
function wrote data in this order:Solution
Reordered the column definitions in
get_non_hidden_columns()
to match the data writing sequence inwrite_to_markdown()
. Now both the headers and data follow the same order:Testing
Fixes #568.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.