-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Refactor generate-release.sh for .speckit subfolder structure #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add --package flag to create release packages (claude, gemini, copilot) - Add --cleanup flag to remove generated folders and zip files - Add SPECKIT_DIR variable for configurable directory naming - Implement update_speckit_path() function with array-based folder mapping - Fix macOS BSD sed compatibility (remove \b word boundaries) - Update file copying to handle hidden directories with sdd-base-package/. - Replace hardcoded .speckit references with $SPECKIT_DIR variable - Consolidate path updates for memory/, scripts/, and templates/ folders
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the generate-release.sh script to support a configurable .speckit
subfolder structure for packaging release templates. The main purpose is to standardize file organization across different AI assistant packages (Claude, Gemini, Copilot) and fix compatibility issues with macOS.
Key changes:
- Introduced configurable
.speckit
directory structure for template packaging - Consolidated packaging logic into a single reusable script with command-line flags
- Fixed macOS BSD sed compatibility and improved cross-platform support
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
.github/workflows/scripts/generate-release.sh | New comprehensive release script with configurable directory structure and multiple packaging options |
.github/workflows/release.yml | Simplified to use the new release script instead of inline bash |
.github/workflows/manual-release.yml | Simplified to use the new release script instead of inline bash |
templates/plan-template.md | Updated path reference from specs/ to /specs/ |
templates/commands/tasks.md | Updated script path from scripts/ to /scripts/ |
templates/commands/specify.md | Updated script and template paths to use absolute paths |
templates/commands/plan.md | Updated script path from scripts/ to /scripts/ |
src/specify_cli/init copy.py | Complete CLI tool implementation for project initialization |
spec-driven.md | Updated documentation paths to use absolute path format |
README.md | Updated example paths to use absolute path format |
CONTRIBUTING.md | Updated folder references to use absolute path format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hi @mkellerman, |
@localden I would love to resolve conflicts, and complete this PR, but only if there is a chance that this might get merged in. So some kind of 👍 would let me know to continue working on this. |
@mkellerman thank you for the contribution - I refactored things a bit differently in the latest release. Check them out and see if there is anything that stands out or that I missed. |
Proposal fix for issue #38
I would consider additional changes:
move all agentic commands in their own subfolder, ex:
.claude/commands/speckit/*
as these might collide with commands the user uses himself or from other projects.